Does the code follow the architecture design(Folder structure,Exception framework,log,error code…)?
Does the code follows coding standard(the name of variable and method,indent,comment,…)?
Are assertions used everywhere data is expected to have a valid value or range?
Are resources and memory released in all error paths?
Are all thrown exceptions handled properly?
Is allocated resources (db connections,sockets,files,etc.) freed?
Are all global,static and shared variables thread-safe?
Are locks released in the same order they are obtained(avoid dead lock)?
Are there any complex SQL, are they reasonable?
Are function parameters explicitly verified in the code?
Are arrays explicitly checked for out-of-bound indexes?
Are there any bad smells (duplicate code,…)?
评论列表
文章目录